Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 61
Add native types to public API#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:3.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Conversation
fb61ef0 to b25a4dfCompareb25a4df to 9ea8a4bCompare
SimonFrings left a comment • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review is done, found a few things that I commented on. I also went through all classes to be sure we don't miss anything and noticed that these following classes are missing types on their public functions:
Model/MessageProtocol/BinaryDumperProtocol/ParserQuery/QueryQuery/RetryExecutor
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus commented Jun 12, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Sweet, thanks! Made all the updates locally. But will push them all in one go once I've also done your other comment.
Last time I checked, those classes aren't part of our public API, except the |
9ea8a4b to 6c7b3afCompareSimonFrings commented Jun 13, 2024
@WyriHaximus Yeah, I also talked with @clue what would count as public API and I think everything that isn't marked as internal or private. Except we recommend not using certain public functions in our README, but didn't find anything about this in our documentation. Maybe there were some decisions made back in the days but never documented, which makes it hard for me to differentiate it from the rest of the public API. |
WyriHaximus commented Jun 13, 2024
That was my assumption. But it's fine, it would have been added in the followup PR anyway.
Not really, it was an assumption, and the previous packages where so small everything was the public API in both ways. |
7e4dfbf to ab9fc67Compare
SimonFrings left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, found a few minor things, should be quick fixes 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ab9fc67 to 1e20620CompareThis changeset adds native types to the public API as discussed in reactphp#219. Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types. Builds on top of reactphp#222, reactphp#223 and reactphp/cache#60
1e20620 to 1101b86Compare
SimonFrings left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, PR looks good to me 👍
This changeset adds native types to the public API as discussed in #219.
Once merged, I'm planning to add PHPStan in a follow-up PR which would take advantage of these types.
Builds on top of #222, #223 and reactphp/cache#60