Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 131
Add support for signal handling#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <?php | ||
| require __DIR__ . '/../vendor/autoload.php' | ||
| $loop = React\EventLoop\Factory::create(); | ||
| $loop->addSignal(SIGINT, $func = function ($signal) use ($loop, &$func){ | ||
| echo 'Signal: ', (string)$signal, PHP_EOL; | ||
| $loop->removeSignal(SIGINT, $func); | ||
| }); | ||
| $loop->run(); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -326,6 +326,41 @@ public function isTimerActive(TimerInterface $timer); | ||
| */ | ||
| public function futureTick(callable $listener); | ||
| /** | ||
| * Registers a signal listener with the loop, which | ||
| * on it's turn registers it with a signal handler | ||
| * suitable for the loop implementation. | ||
| * | ||
| * A listener can only be added once, any attempts | ||
| * to add it again will be ignored. | ||
| * | ||
| * See also [example #4](examples). | ||
| * | ||
| * @param int $signal | ||
| * @param callable $listener | ||
| * | ||
| * @throws \BadMethodCallException when signals | ||
| * aren't supported by the loop, e.g. when required | ||
| * extensions are missing. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function addSignal($signal, callable $listener); | ||
| /** | ||
| * Removed previous registered signal listener from | ||
| * the loop, which on it's turn removes it from the | ||
| * underlying signal handler. | ||
| * | ||
| * See also [example #4](examples). | ||
| * | ||
| * @param int $signal | ||
| * @param callable $listener | ||
| * | ||
| * @return void | ||
| */ | ||
| public function removeSignal($signal, callable $listener); | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can the same listener be added multiple times? If so, which one will be removed here? Also, the docs should probably include what happens if the given signal or listener is not attached (NO-OP just like other methods?). | ||
| /** | ||
| * Run the event loop until there are no more tasks to perform. | ||
| */ | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objection to this limitation, but I would suggest making sure this is closer to the verbiage for our stream API (https://github.com/reactphp/event-loop/pull/110/files#diff-04c6e90faac2675aa89e2176d2eec7d8R312). What do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it, it isn't my strongest skill and I rather not let it block this PR thus I suggest if it needs work I do it in a follow up PR.