Improve test suite to be less fragile#144
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR improves the test suite to use less fragile assumptions for the timer tests and avoids related warnings about "risky" tests by PHPUnit.
The old test suite works fine on Travis, but reports these "risky" tests. For some reason, the test suite failed on my local machine when using
ext-event, despite using same PHP version, same PECL version and same composer packages as seen on Travis: https://gist.github.com/clue/8216c7494769d31dd0c6279a0a27ed7bThe updated test suite avoids blocking the loop and thus makes these tests less fragile.
Builds on top of #138 and #120