Skip to content

Mark legacy extensions as deprecated and minor documentation improvements#234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
Jul 10, 2021
Merged

Mark legacy extensions as deprecated and minor documentation improvements #234

WyriHaximus merged 1 commit into from
Jul 10, 2021

Conversation

@SimonFrings
Copy link
Member

@SimonFringsSimonFrings commented Jul 6, 2021

The maintenance for ExtLibeventLoop and ExtLibevLoop hasn't seen an update since 2013. It's time to move on.

@clueclue added this to the v1.2.0 milestone Jul 6, 2021
clue
clue reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@clueclue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thank you for looking into this, this deprecation notice is indeed long overdue (#40, #55, #62 and many others such as #230). Only added some minor remarks below, otherwise LGTM 👍

src/ExtLibevLoop.php Outdated
useSplObjectStorage;

/**
* Deprecated since v1.2.0, use [`ExtEvLoop`](#extevloop) instead.
Copy link
Member

@clueclueJul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably use a @deprecated annotation similar to https://github.com/reactphp/event-loop/pull/231/files#diff-f1158fbec0bb446d87dbd5346fba683c58ccec1a98b1787511ec7786585e8c31R8 instead 👍

Copy link
MemberAuthor

@SimonFringsSimonFringsJul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@clueclue changed the title Mark extensions deprecated and minor docs improvementMark legacy extensions as deprecated and minor documentation improvementsJul 6, 2021
clue
clue approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@clueclue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clueclue requested a review from WyriHaximusJuly 10, 2021 19:40
@WyriHaximusWyriHaximus merged commit e3287d6 into reactphp:masterJul 10, 2021
@clueclue mentioned this pull request Feb 2, 2024
Merged
@clueclue mentioned this pull request May 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximusWyriHaximusWyriHaximus approved these changes

@clueclueclue approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonFrings@WyriHaximus@clue