Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 38
Rewrite#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite #97
Uh oh!
There was an error while loading. Please reload this page.
Conversation
WyriHaximus commented Oct 6, 2021 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
9e4fc37 to 7be39ffCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5e6f62c to 6eb3c14Compare7a1615c to e34ce17CompareWyriHaximus commented Feb 8, 2022
@clue@SimonFrings This PR is now fully ready for review. The green build can be found here. And a readable render of the readme here. |
Uh oh!
There was an error while loading. Please reload this page.
SimonFrings left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked over everything and focused on writing and syntax because functional adjustments can always be done in following PRs. If the tests are green, then I am happy ^^
Still some work to do but this is definitely a better version than before, nice work @WyriHaximus 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus commented Feb 9, 2022
@SimonFrings Thanks! Just updated this PR with your suggestions 👍 |
This is a full rewrite of this package including the following features/changes: * ext-uv adapter * child process adapter * fallback (blocking) adapter (for native Windows) * simplified the internals to remove unnecessary complexity * file_get_contents/file_put_contents like API to read/write from/to files * start has become an object instead of an array This PR doesn't include the following features/changes as those will be added in with followup PR's: * ext-eio adapter * macos support * mode support to define permissions when creating files/directories * symlinks read/creating/deleting * deleting of directories
clue left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WyriHaximus Let's get this shipped! ![]()
I agree with everything that's been said, so I only briefly eyeballed this. This may not be perfect (yet), but it's definitely a major improvement over the current experimental filesystem implementation. Let's get this in as-is and build on top of this with future PRs 👍
WyriHaximus commented Feb 9, 2022
@clue 🚢 🇮🇹 !
Already on it! #99 |
This is a full rewrite of this package including the following features/changes:
This PR doesn't include the following features/changes as those will be added in with followup PR's:
cc: @SimonFrings