Emit end event for requests without body#136
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus approved these changes Mar 2, 2017
clue requested changes Mar 2, 2017
src/Server.php Outdated
| $request->emit('end'); | ||
| $request->close(); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
Emitting events on another instance should generally be avoided. Also, this looks somewhat similar to the code below, perhaps this can/should be unified?
legionthforce-pushed the handle-simple-requests branch from 0df5dc8 to 26fb646Compare
ContributorAuthor
legionth commented Mar 2, 2017
Ping @clue have a look at this new approach. |
jsor approved these changes Mar 3, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only requests with a body will emit the
endevent ( #116 and #129).This ensures that a completed request without a body (e.g. GET-Request) will emit an
endevent.