Forward compatibility with Stream v1.0 and v0.7#184
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsor approved these changes May 15, 2017
MemberAuthor
clue commented May 15, 2017
Updated to simplify buffering tests by using new react/promise-stream release |
Member
WyriHaximus commented May 15, 2017
@clue changes look good, but any idea why the |
MemberAuthor
clue commented May 15, 2017
@WyriHaximus Updated the first commit to target at least react/stream v0.4.6 which contains a bugfix for the |
Member
WyriHaximus commented May 15, 2017
Cheers 👍 |
WyriHaximus approved these changes May 15, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #183