Prevent exception if underlying socket is a unix socket#234
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| if (isset($remoteAddress['port'])){ | ||
| $serverParams['REMOTE_ADDR'] = $remoteAddress['host']; | ||
| $serverParams['REMOTE_PORT'] = $remoteAddress['port']; | ||
| } |
There was a problem hiding this comment.
But the REMOTE_ADDR should still be set, no? I guess the port could just be set to 0.
There was a problem hiding this comment.
In case of OSX I get ________ as REMOTE_ADDR so I've removed both.
clue left a comment
clue left a comment There was a problem hiding this comment.
Thanks for filing this PR! I would like to look into this in more detail, can you add a test case that triggers this behavior and the expected output? 👍
| publicfunctiontestUnixRemoteSocketWithoutPort() | ||
| { | ||
| // reactphp/socket Connect->parseAddress returns "tcp://NUL" for UDS | ||
| $parser = newRequestHeaderParser(null, 'tcp://' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . ''); |
There was a problem hiding this comment.
See https://bugs.php.net/bug.php?id=74556. Thats what PHP returns for stream address of UDS on OSX. I would appreciated upvotes on the bug.
There was a problem hiding this comment.
@andig Thanks for the update!
Have you seen reactphp/socket#100? IMO this should be handled by the Socket component, which is also where this address comes from (afaict). This way, we would likely expect a null address here. Does this make sense to you?
There was a problem hiding this comment.
Why do you want upvotes on an already fixed bug? But it's not what I asked. You write "\0" . '' . "\0" there instead of simply "\0\0", why that?
There was a problem hiding this comment.
You write "\0" . '' . "\0" there instead of simply "\0\0", why that?
That was copy/paste from var_export, will fix.
3 participants
Partial UDS support for #231