Forward compatibility with PHPUnit 6#243
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus approved these changes Nov 12, 2017
Member
WyriHaximus left a comment
WyriHaximus left a comment There was a problem hiding this comment.
👍 Makes perfect sense to make, paves the road to PHPUnit 6 and beyond
Contributor
andig commented Nov 12, 2017
According to reactphp/socket#132 it should be 5.7.11 as min version. |
clue reviewed Nov 13, 2017
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
Thank for you digging into this and filing this PR! The changes LGTM, does it make sense to you to add support for PHPUnit 6 as part of this PR? 
ContributorAuthor
carusogabriel commented Nov 14, 2017
@clue Done. Added |
clue approved these changes Nov 14, 2017
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
Thank you for the quick update, changes LGTM!
clue changed the title 
jsor approved these changes Nov 14, 2017
Member
clue commented Nov 14, 2017
Rebased now that #244 is in |
WyriHaximus pushed a commit to WyriHaximus/http that referenced this pull request Nov 14, 2017
Forward compatibility with PHPUnit 6
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just need to bump PHPUnit version to
^4.8.35and^5.7, that support this namespace.