Keep incoming Transfer-Encoding: chunked request header#316
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus approved these changes Apr 7, 2018
jsor approved these changes Apr 9, 2018
MemberAuthor
clue commented Apr 9, 2018
Rebased on master to resolve merge conflict now that #315 is in |
Member
WyriHaximus commented Apr 9, 2018
👍 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR ensures that we keep the incoming
Transfer-Encoding: chunkedheader as-is. This is in line with how we handle other request headers (#262) and also how other servers seem to handle this header. The original behavior (#137) made sense back when the server would theoretically accept alternative transfer encodings, but this option has explicitly been removed a while ago anyway (#140).Refs #262
Refs #137
Refs #140