Skip to content

Avoid unneeded warning when decoding invalid data on PHP 7.4#357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsor merged 1 commit into from
Jan 12, 2020
Merged

Avoid unneeded warning when decoding invalid data on PHP 7.4 #357

jsor merged 1 commit into from
Jan 12, 2020

Conversation

@WyriHaximus
Copy link
Member

@WyriHaximusWyriHaximus commented Jan 11, 2020•
edited
Loading

Supersedes / Closes#356
Refs: reactphp/http-client#150

@WyriHaximusWyriHaximus added this to the v0.8.6 milestone Jan 11, 2020
@WyriHaximusWyriHaximus requested review from clue and jsorJanuary 11, 2020 20:40
clue
clue reviewed Jan 12, 2020
View reviewed changes
clue
clue reviewed Jan 12, 2020
View reviewed changes
Copy link
Member

@clueclue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit 7+ reports a warning due to unsupported XML definition, otherwise LGTM 👍

@WyriHaximusWyriHaximus requested a review from clueJanuary 12, 2020 12:36
@jsorjsor merged commit 248202e into reactphp:masterJan 12, 2020
@clueclue mentioned this pull request Aug 31, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsorjsorjsor approved these changes

@clueclueclue approved these changes

Assignees

No one assigned

Labels

bugeasy pick

Projects

None yet

Milestone

v0.8.6

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@jsor@clue