Skip to content

Conversation

@clue
Copy link
Member

@clueclue commented Jul 25, 2020

This changeset improves the base URL logic to consistently resolve base URL according to HTTP specs (https://tools.ietf.org/html/rfc3986#section-5.2).

// new: will request http://api.example.com/v2/users$browser = $browser->withBase('http://api.example.com/v3/'); $browser->get('../v2/users')->then(…);

I consider this to be a feature addition and not a BC break because the previous behavior was both unclear and not well-defined. This now follows common URL resolving logic supporting relative references such as ../,./ and others.

@clueclue added this to the v1.1.0 milestone Jul 25, 2020
@clueclue requested review from WyriHaximus and jsorJuly 26, 2020 12:58
@jsorjsor merged commit 7873a87 into reactphp:masterJul 26, 2020
@clueclue deleted the resolve-base-url branch July 27, 2020 08:34
clue added a commit to clue-labs/reactphp-docker that referenced this pull request Jul 28, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@jsor@WyriHaximus