Internal refactoring to remove internal Response class, now uses PSR-7 response instead#389
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsor approved these changes Aug 30, 2020
WyriHaximus approved these changes Aug 30, 2020
This was referenced Nov 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset performs some internal refactoring and cleanup. In particular, it removes the duplicate
Client\Responseclass that has been introduced temporarily via #368.Besides improving our internal code structure, this is also useful because IDE autocompletion no longer suggests this class when dependents are looking for a response class. The correct class continues to exist in
Message\Responseas of #370. Accordingly, this does not affect the public API, so this is not a BC break.Additionally, this is also needed in preparation for HTTP keepalive support (#39) and client-side connection upgrades (#376). A longer-term goal is to remove the entire
Clientnamespace (entirely internal).Builds on top of #372, #380, #381 and others.