Skip to content

Conversation

@clue
Copy link
Member

@clueclue commented Jul 27, 2021

This changeset simplifies usage by supporting the new Socket API without nullable loop arguments.

// old$http = newReact\Http\HttpServer($handler); $http->listen(newReact\Socket\Server(8080)); // new$http = newReact\Http\HttpServer($handler); $http->listen(newReact\Socket\SocketServer('127.0.0.1:8080'));

Note that this doesn't affect the API of this package at all, but does use the improved API of the referenced Socket component. Existing code continues to work as is.

Together with #418, #417 and #410, this means we can now fully rely on the default loop and no longer need to skip any arguments with null values. Additionally, this now consistently uses the HttpServer and SocketServer class names to avoid class name collisions and ambiguities.

Builds on top of reactphp/socket#264 and reactphp/socket#263

@clueclue added this to the v1.5.0 milestone Jul 27, 2021
@clueclueforce-pushed the socket branch 2 times, most recently from 59f1d20 to 18906cbCompareAugust 3, 2021 13:16
@clueclue changed the title [WIP] Simplify usage by supporting new Socket API without nullable loop argumentsSimplify usage by supporting new Socket API without nullable loop argumentsAug 3, 2021
@clue
Copy link
MemberAuthor

clue commented Aug 3, 2021

Rebased now that #418 has been merged and Socket v1.9.0 has been released :shipit:

@clueclue requested a review from WyriHaximusAugust 3, 2021 13:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus