Refactor HTTP message parsing to build on top of new PSR-7 implementation#520
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SimonFrings approved these changes Mar 22, 2024
Member
SimonFrings left a comment
SimonFrings left a comment There was a problem hiding this comment.
Went through all changes, looks good so let's get this shipped 👍
This was referenced Mar 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset refactors the HTTP message parsing logic in the internal
ClientRequestStreamandRequestHeaderParserclasses to build on top of a new PSR-7 implementation. This brings us one step closer to eventually replace the dated RingCentral implementation (#331) and eventually support PSR-7 v2 (#513). Most notably, this means theBrowserwill now return instances of ourResponseclass (#518) instead of using the legacy RingCentral classes.Other than that, this is a purely internal change that comes with 100% code coverage and does not otherwise affect the public API, so it should be safe to apply. I've tried to keep changes to a minimum to ease review, but there's definitely some room for improvement in follow-up PRs.
This builds on top of the recent changes for the
ResponseandServerRequestclasses (#518 and #519), but this time doesn't show a noticeable impact on performance during my benchmarks. As a consequence, I consider this mostly an internal refactoring only.Once merged, I'll file follow-up PRs to refactor the
Uriclass accordingly. If you enjoy this change and want to help us continue to ship more improvements, consider supporting this project, for example by becoming a sponsor ❤️Builds on top of #519, #518, #480, #432, #370, #170 and others