Run tests on PHP 8.4 and update test environment#271
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jrfnl reviewed Aug 18, 2025
...FunctionSetRejectionHandlerThatTriggersDefaultHandlerShouldTerminateProgramForUnhandled.phpt Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus approved these changes Aug 19, 2025
Member
WyriHaximus left a comment
WyriHaximus left a comment There was a problem hiding this comment.
Looks good to me, thanks for spotting that bug @jrfnl 👍
WyriHaximus merged commit 23444f5 into reactphp:3.x 17 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #261, #260, #249 and clue/framework-x#267
Supersedes / closes#266
Supersedes / closes#267
Supersedes / closes#268