Skip to content

Conversation

@andig
Copy link
Contributor

@andigandig commented Oct 7, 2017

This is an improvement over #92 that handles the new OSX-specific failure introduced by the initial fix for https://bugs.php.net/bug.php?id=74556.

andig added a commit to andig/php-pm that referenced this pull request Oct 7, 2017
@clueclue added this to the v0.8.5 milestone Oct 7, 2017
@clueclue changed the title Address OSX-specific PHP bug 74556Fix Unix domain socket (UDS) paths for Mac OS XOct 7, 2017
clue
clue approved these changes Oct 7, 2017
Copy link
Member

@clueclue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting, reporting this upstream and filing this here! LGTM, let's get this in :shipit:

jsor
jsor approved these changes Oct 7, 2017
@clue
Copy link
Member

clue commented Oct 7, 2017

For the reference: This fix builds on top of #100 which landed in v0.8.0. Both are actually work-arounds for bugs in PHP, the first of which has been fixed in PHP 7.1.7 and the second has just been merged today and is due in the next PHP release.

Copy link
Member

@WyriHaximusWyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WyriHaximusWyriHaximus merged commit e621ea2 into reactphp:masterOct 7, 2017
@andigandig deleted the php74556 branch October 7, 2017 20:02
@jsorjsor mentioned this pull request Oct 7, 2017
@andig
Copy link
ContributorAuthor

Would it be possible to release this as soon as possible? Would be nice to get UDS support into the wild without depending on dev-master.

@clueclue changed the title Fix Unix domain socket (UDS) paths for Mac OS XWork around Unix domain socket (UDS) paths for Mac OS XOct 23, 2017
@clue
Copy link
Member

clue commented Nov 9, 2017

For the reference: This work-around is no longer required in PHP versions 7.0.25+ and 7.1.11+ now that the fix is in via php/php-src@843e492. This work-around does no harm and we'll keep this to support older PHP versions 👍

@WyriHaximus
Copy link
Member

@andig FYI https://github.com/reactphp/socket/releases/tag/v0.8.6 🎉

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andig@clue@WyriHaximus@jsor