Improve TLS error messages (Connection lost during TLS handshake)#169
+149 −34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2018
MemberAuthor
clue commented Sep 23, 2018
Rebased on current master and updated to skip testing platform specific TLS error message strings |
WyriHaximus approved these changes Sep 24, 2018
jsor approved these changes Sep 25, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP does not seem to report any warning message when the connection is lost (closed by the remote side) during a TLS handshake (both client and server side). As a result of this, the previous message appeared to be cut off. This PR ensures we indicate this error with proper errno/errstr.
Refs #168