ConnectionInterface should extend DuplexStreamInterface + documentation#50
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the
ConnectionInterfaceactually extends theDuplexStreamInterfaceintroduced with react/stream v0.4.2. Thus, the main difference here is this:Note that this is not a BC break because the
DuplexStreamInterfaceactually extends bothReadableStreamInterfaceandWritableStreamInterface.Also update the documentation to emphasize this is the main interface that is to be used to represent incoming connections.