Replace custom ConnectionException with generic RuntimeException#72
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus approved these changes Feb 8, 2017
jsor approved these changes Feb 8, 2017
clue added a commit to clue-labs/socket that referenced this pull request Mar 29, 2017
Replace SecureStream with unlimited read buffer from react/stream v0.4.5
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR replaces the undocumented
ConnectionExceptionwith a genericRuntimeException.Also adds some documentation for when this occurs and is now in line with other exceptions described in #60 and #61.
Extending the
ErrorExceptiondoesn't really make any sense, because we never actually supported any of its properties.This change introduces a small BC break, but I figured it's worth it because it reduces the API footprint further (refs #71 and #70) and makes sure our exception usage is consistent across this project.
Also closes#56 while we're at it