Rename Server to TcpServer#96
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
clue commented Apr 24, 2017
Rebased on current master to fix failing tests |
jsor approved these changes Apr 24, 2017
WyriHaximus approved these changes Apr 25, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR renames the
Serverclass toTcpServer.A follow-up PR will introduce a new
Serverclass which acts as a facade for the existing server classes. This class allows to start aTcpServeras-is and will prepare the code for the upcoming Unix domain socket server (#25) and upcomingSecureServerwith auto-generated certificates (#95). This will work very similar to how theConnectorclass is a facade for the client side connector classes.In other words, the follow-up PR will restore compatibility with consumer code so this does in fact not result in a BC break for most users.