Define url_options as per system test case does#2329
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
benoittgt commented May 9, 2020
I don't have anymore timeout with the PR, but I had no timeout with I think the problem is related to this: If you do : --- a/Gemfile+++ b/Gemfile@@ -5,6 +5,9 @@ ruby '2.6.6' # Bundle edge Rails instead: gem 'rails', github: 'rails/rails' gem 'rails', '6.0.0.rc1' +gem 'actionpack', '6.0.0.rc1'+gem 'activesupport', '6.0.0.rc1'+gem 'railties', '6.0.0.rc1'You do no have the timeout anymore. 🤔 |
nnc commented May 9, 2020
@benoittgt Rails 6.0.0.rc1 doesn't have the timeout issue because the problem was first introduced in Rails 6.0.1.rc1. Everything before that, including 6.0.0.rc1 is OK for me as well. |
benoittgt commented May 9, 2020
Sorry... 🤦 |
JonRoweforce-pushed the fix-system-examples-default-host branch 3 times, most recently from 443fa2b to 429160dCompare
| Then the output should contain "1 example, 0 failures" | ||
| And the output should not contain "starting Puma" | ||
| And the exit status should be 0 | ||
| And the exit status should be 0 or I debug |
There was a problem hiding this comment.
If you understand why, I am interested. I wrote this #2325 (comment)
JonRoweforce-pushed the fix-system-examples-default-host branch from 429160d to 7d0a9afCompareJonRoweforce-pushed the fix-system-examples-default-host branch 2 times, most recently from 49b14cb to 0623e8aCompareJonRoweforce-pushed the fix-system-examples-default-host branch from 0623e8a to 1b0cc7bCompare
JonRoweforce-pushed the fix-system-examples-default-host branch from 1b0cc7b to 08182d3Compare3 participants
Rails switched to manually defining
url_optionswhen they switched away from inheriting from integration test case.See:
rails/rails@ea77dbf#diff-ff5f366a442b8761d35f94807700fa77R162
This should fix#2327