Skip to content

Conversation

@pirj
Copy link
Member

@pirjpirj commented Jul 30, 2021

It was introduced in rspec/rspec-core#2895

When RSpec.current_scope is released in 3.11 and 4.0, we're fine with merging this PR to main and to 5-0-maintenance.

TODO:

  • remove the temp! commit

@pirjpirj self-assigned this Jul 30, 2021
@pirjpirjforce-pushed the use-rspec-current_scope branch from eb53bde to dd06392CompareJuly 30, 2021 17:14
@pirjpirj requested review from JonRowe and benoittgtJuly 30, 2021 17:46
@pirjpirj marked this pull request as ready for review July 30, 2021 17:46
Copy link
Member

@JonRoweJonRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For when the other PR is merged, this gets a thumbs up (without the temp pin commit of course).

@pirj
Copy link
MemberAuthor

pirj commented Aug 15, 2021

If I merge now, I'll surely forget to cherry-pick to 5-0-maintenance.

If I cherry-pick it to 5-0-maintenance, I would have to bump expected_rspec_version in gemspec to the yet unreleased 3.11.0.

In theory, pointing to 3.11.0 might break someone's setup if they prefer using 5-0-maintenance with the latest unreleased fixes to 5.0.x.
In practice, though, there are no changes since 5.0.2, so for those using github: ..., branch ... there's a workaround to use ~> 5.0.

If I forget to cherry-pick to 5-0-maintenance, it will only be available for the future 6.0 release. Not a big deal, though.

This process requires thinking and having good memory.
I intend to hold off merging this until 3.11.0 is released, does this sound reasonable?

@JonRowe
Copy link
Member

I don't think this should be merged to 5-0-maintenance as I don't think its a good idea to bump a dependency in a patch version, only a minor. However this also would gate any release of rspec-rails5.1 on 3.11 so its probably still worth holding off merging.

@pirjpirj added this to the 6.0 milestone Dec 13, 2021
@JonRoweJonRowe mentioned this pull request Jan 18, 2022
21 tasks
@JonRoweJonRowe merged commit 620a869 into mainFeb 9, 2022
@JonRoweJonRowe deleted the use-rspec-current_scope branch February 9, 2022 11:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pirj@JonRowe