WIP: Switch to markdown and fix code blocks#49
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @markburns and thanks for making the book available!
I'm currently going over it to give it a style refresh/fix. This is still a work in progress but I wanted to share already so that if anyone want to discuss my choices it can be done here.
While first reading the repository I also had some troubles guessing which was the correct branch to work on. I've chosen the
masterand I think it should be made default (and maybe renamedmain).Since I'm reading the book at the same time as I am doing this PR, I may also fix some typos. I'll prefix typo related commits with
typo:if there are some for one to be able to review those separately.If you do not want to maintain the repository anymore, I'd be glad to help as well 🙂. However, I am French and my English is far from perfect (and I don't know anything about Japanese). Hence my focus being on style and minor typos.
Best,
Ulysse
Fixes#47
TODO:
_config.yml, remove useless configuration.I had a lot of difficulties while reading this great book, and most
where related to code blocks being badly formatted. For instance, the
RCLASS(tmp)->iv_tblwould render asRCLASS->iv_tbl.Rather than fixing textile which really is not the goto language
nowadays. I've made another attempt to switch to markdown (seeing that
the former wasn't successful).
I've done that using the script below, and allowing myself a few
changes:
figurehtml tags, and show captions below,