🐛 Fix SequenceSet#xor crash when set is frozen#457
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nevans changed the base branch from sequence_set/fix-slice-inconsistent-frozen to masternevansforce-pushed the sequence_set/fix-xor-should-not-modify-self branch from 6f4560d to 79fb1e6Compare`set ^ other` and `set.xor other` are supposed to be safe transforms. But, unfortunately, they modified the receiver if it wasn't frozen, and crashed when it was! The fix is trivial: convert `self` to `dup`.
nevansforce-pushed the sequence_set/fix-xor-should-not-modify-self branch from 79fb1e6 to fa722c4Comparenevans merged commit 59f259e into master 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
nevans changed the title SequenceSet#xor should not modify selfSequenceSet#xor crash when set is frozennevans added the sequence-set Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set ^ otherandset.xor otherare supposed to be safe transforms. But, unfortunately, they modified the receiver if it wasn't frozen,The fix is trivial: convert
selftodup.Edited later to add: The bug wasn't as severe as I thought when I wrote the ticket and commit notes.
(self | other)always returns a newSequenceSetso the original is unmodified. The test failed becauseSequenceSet#|returns a new set with the same frozen status as the receiver. But as a performance optimization, the#xorimplementation uses(self | other).subtract(...)rather than(self | other) - .... So, whenselfis frozen, the result of(self | other)will be frozen too, and `subtract will crash (as the test showed).