Skip to content

♻️ Short-circuit frozen SequenceSet modifications#473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nevans merged 1 commit into from
May 6, 2025
Merged

♻️ Short-circuit frozen SequenceSet modifications #473

nevans merged 1 commit into from
May 6, 2025

Conversation

@nevans
Copy link
Collaborator

@nevansnevans commented May 5, 2025•
edited
Loading

Short-circuit frozen SequenceSet modifications for two reasons:

  • Skip coercing inputs or calling (relatively expensive) query methods.
  • Normalize the output for JRuby, which doesn't appear to use #inspect for its built-in frozen error (see Add JRuby and TruffleRuby to CI #454).

@nevans
✅ Short-circuit frozen SequenceSet modifications
4f50e60
Short-circuit frozen SequenceSet modifications does two things: * avoids unnecessarily coercing inputs or calling query methods * normalizes the output for JRuby
@nevansnevans merged commit f117dbd into masterMay 6, 2025
35 of 37 checks passed
@nevansnevans deleted the sequence_set/modifying branch May 6, 2025 15:16
@nevansnevans mentioned this pull request May 7, 2025
Closed
@nevansnevans changed the title ✅ Short-circuit frozen SequenceSet modifications♻️ Short-circuit frozen SequenceSet modificationsMay 8, 2025
@nevansnevans mentioned this pull request Oct 9, 2025
Open
@nevansnevans added the sequence-set Any code the IMAP `sequence-set` data type or grammar rule, especially the SequenceSet class. label Dec 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sequence-setAny code the IMAP `sequence-set` data type or grammar rule, especially the SequenceSet class.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nevans