✅ Update ResponseReader, UIDFetchData, DeprecatedClientOptions tests#476
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TruffleRuby handles `io.gets(CRLF, limit)` differently when the limit cuts in the middle of the terminator. It's helpful behavior, but it's different enough to break the tests.
Different parts of these test pass or fail on TruffleRuby or JRuby, so I'm splitting them off into their own tests.
These tests weren't even using the correct port for the fake server, so there is reason to start it up at all. Also, we have issues with reliably shutting the server down after an error, for both TruffleRuby and JRuby.
nevans changed the title nevans changed the title nevans merged commit dc8004d into master 35 of 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits up
ResponseReadertests and UIDFetchData into more fine-grained tests. Different parts of these test pass or fail on TruffleRuby or JRuby, so splitting them off into their own tests lets us mark only specific bits as pending or omitted.The DeprecatedClientOptions tests weren't even using the correct port for the fake server, and weren't supposed to be capable of connecting anyway, so there is reason to start the server up at all. Also, we have issues with reliably shutting the server down after an error, for both TruffleRuby and JRuby.
(See #470.)