🐛 Fix SequenceSet#include? handling of invalid inputs#479
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The rdoc said it returned `false`, but it actually crashed. I've fixed it to return `nil` and modified the docs to match.
nevans changed the title SequenceSet#include?: handling invalid inputs, bad rdoc exampleSequenceSet#include? handling of invalid inputsnevans merged commit 8c5bdc9 into master 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
nevans added the sequence-set Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rdoc said it returned
false, but it actually crashed. It's sometimes useful to make the distinction between invalid input and valid input with a false return value, so I've updated so invalid input returnsnil(and updated the rdoc to match).Also, some of the rdoc examples were simply wrong. Maybe a copy/paste error from
#intersect?