♻️ Avoid unnecessary allocation in SequenceSet[]#492
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This updates the behavior of `SequenceSet[]` so that a frozen result from `input.to_sequence_set` is returned directly, not duplicated. It is also updated to delegate to `SequenceSet.try_convert`.
nevans merged commit 55f5ca1 into master 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
nevans added the sequence-set Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
SequenceSet[]so a frozen result frominput.to_sequence_setis returned directly, not duplicated.It is also updated to delegate to
SequenceSet.try_convert.