✨ Add ESearchResult#to_sequence_set#511
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nevans changed the title obj.to_sequence_set => nil in try_convertESearchResult#to_sequence_setnevans changed the base branch from master to sequence_set/allow-to_sequence_set-nil Base automatically changed from sequence_set/allow-to_sequence_set-nil to masterAugust 29, 2025 16:34
Similar to `SearchResult`, this method allows ESearchResult to be used as an argument where a SequenceSet is required, such as with `#fetch`. This also updates `ESearchResult#to_a` to use `to_sequence_set.numbers`.
nevansforce-pushed the esearch-to_sequence_set branch from f134206 to 93ec2c3Comparenevans merged commit 82763e1 into master 37 checks passed
Uh oh!
There was an error while loading. Please reload this page.
nevans added the sequence-set Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
SearchResult, this method allows ESearchResult to be usedas an argument where a SequenceSet is required, such as with
#fetch.This also updates
ESearchResult#to_ato useto_sequence_set.numbers.