♻️ Allow VanishedData#uids to be SequenceSet.empty#517
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nevans changed the title VanishedData#uids to be SequenceSet.emptyThis isn't a valid server response. But it's useful as a null object.
nevansforce-pushed the allow-vanished_data-uids-to-be-empty branch from 2eee916 to 46617a7Comparenevans merged commit 85fcc81 into master 57 of 69 checks passed
Uh oh!
There was an error while loading. Please reload this page.
nevans added the sequence-set Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a valid server response. But it's useful as a null object. It will be used when
Net::IMAP#uid_fetchis called withvanished: truebut the server returns nothing.