Expand Zip to up to 9 producers#1559
Merged
+56 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
akern40 commented Jan 10, 2026
@felsenhower would you mind taking a look at these CI issues and resolving them? |
ContributorAuthor
felsenhower commented Jan 12, 2026
Sorry for the delay. I think I've resolved the issue. |
Collaborator
nilgoyette commented Jan 12, 2026
You still have a tiny fmt error. |
ContributorAuthor
felsenhower commented Jan 12, 2026
Apologies again. That should've fixed it now. |
Collaborator
nilgoyette commented Jan 12, 2026
Thank you for your contribution @felsenhower |
nilgoyette merged commit f6a3205 into rust-ndarray:master 15 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As has been discussed in #1175, I expanded
Zipfor up to 9 producers (includingazip!,par_azip!). Previously, it was only working for up to 6 producers.I also added two simple tests with 9 producers.