Skip to content

Conversation

@Dowwie
Copy link
Contributor

No description provided.

@sfackler
Copy link
Collaborator

Huh, how does a null bound compare to the bound not being present? Are they equivalent?

@sfackler
Copy link
Collaborator

I don't understand - it doesn't look like that code is ever creating a RangeBound with a None in it.

The key question is if the Postgres server understands a present-but-null bound and if it will ever produce one of those.

@sfackler
Copy link
Collaborator

The Ok(Range::new(None, None))? That constructs an unbounded range, not a range bounded by null on both ends.

@Dowwie
Copy link
ContributorAuthor

@sfackler A RangeBound(None)? Is that even a range type in postgres? testing in psql, it returns an exception: DETAIL: Missing left parenthesis or bracket.

Bounds are requirements in Postgres

@sfackler
Copy link
Collaborator

Ok so it sounds like this PR isn't needed then, right?

@DowwieDowwie closed this Oct 15, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Dowwie@sfackler