Skip to content

Conversation

@gclaramunt
Copy link
Contributor

Spanish translation of Basic scala

@gclaramunt
Copy link
ContributorAuthor

Some details are missing (intro and fiddle run), I'll add them asap

@NthPortalNthPortal changed the title Update basics.mdUpdate Spanish translation of basics.mdMay 2, 2019
@NthPortal
Copy link
Contributor

Thanks for doing this! I can't review it as I am not fluent, but it's definitely something we need more of ❤️

@gclaramunt
Copy link
ContributorAuthor

Who can review? I can ask someone who speak Spanish :)

@dwijnand
Copy link
Member

Perhaps @diesalbla, @jvican, and/or @ignasi35 have some spare bandwidth?

Copy link
Contributor

@diesalbladiesalbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.
General changes:

  • Replace "palabra clave" (too direct translation of keyword) by "palabra reservada".
  • Use the singular form, in preference to the plural form.

@gclaramunt
Copy link
ContributorAuthor

Thanks for the review :)

Copy link
Contributor

@ignasi35ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I've left a couple of major comments and a handful of small typo fixes.

@gclaramunt
Copy link
ContributorAuthor

Ya le pase el corrector y en contre un par de tildes mas que faltaban.

@SethTisueSethTisue merged commit bf9e769 into scala:masterMay 7, 2019
@SethTisue
Copy link
Member

thanks all!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@gclaramunt@NthPortal@dwijnand@SethTisue@ignasi35@diesalbla