Skip to content

Conversation

@SethTisue
Copy link
Member

@SethTisueSethTisue commented Jan 26, 2021

@SethTisueSethTisue changed the title update nokogiri to 1.11.1update Ruby to 2.5.8 (was 2.3.1) and nokogiri to 1.11.1Jan 26, 2021
@SethTisueSethTisue marked this pull request as draft January 26, 2021 22:09
@SethTisue
Copy link
MemberAuthor

nokogiri-1.11.1-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is incompatible with the current version, ruby 2.3.1p112 

@sjrd over at scala/scala-lang#1208 I was able to deal with this by bumping the Ruby version in .travis.yml, but in this repo we're on Drone with image: scalacenter/scala-rvm-jvm-coursier:2.0. What do you suggest we do?

  • have someone at the Center update the Drone setup
  • ditch Drone for Travis-CI or GitHub actions
    • context: the original Travis-to-Drone switch was made by Jorge at Add drone.yml and remove travis #685
    • I know Travis-CI but I don't know GitHub Actions, so if we go the Travis-CI route I'd be happy to just adapt the .travis.yml file we use over in the other repo, but if you want to go GitHub Actions instead, I'm not volunteering
  • shrug and kick the problem down the road

?

@sjrd
Copy link
Member

sjrd commented Jan 27, 2021

I'll put this up for discussion at the Center, and see if someone could take care of Drone or migrate to GitHub Actions. I don't think we should move anything to Travis at this point.

@vincenzobaz
Copy link
Contributor

I am working on migrating to Github Actions in this PR

@vincenzobaz
Copy link
Contributor

The ruby version is set in .github/workflows/build.yml, in theory changing Gemfile.lock and rebasing/merging on mastter shoud give you a green ci

@SethTisueSethTisue marked this pull request as ready for review January 27, 2021 16:03
@SethTisueSethTisue merged commit 8828d79 into scala:masterJan 27, 2021
@SethTisueSethTisue deleted the nokogiri branch January 27, 2021 17:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@SethTisue@sjrd@vincenzobaz