Skip to content

Conversation

@pikinier20
Copy link
Contributor

@pikinier20pikinier20 commented Jul 29, 2021

This PR is related to #12987

closes#12843

@julienrfjulienrf self-assigned this Jul 29, 2021
@pikinier20pikinier20force-pushed the snippet-compiler-docs branch 2 times, most recently from 22f988d to 1183cd0CompareJuly 30, 2021 15:09
Copy link
Contributor

@julienrfjulienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to write some documentation!

Besides the specific comments I left, I have the following general recommendations. The reference documentation should first and foremost answer the following questions: what can I do? And how do I do it? Other questions such as “how does that work under the hood” are secondary and should come after the main content, IMHO. Also, I don’t think we should give too much background explanation about why and how you introduced this or that feature (that content would be great for a blog post, though, or for the scala3/scaladoc.md page). I mean, it’s always good to first show some motivating example/content before showing a feature, but we don’t necessarily want to hear all the story behind. I hope this helps :)

Do you mind attaching a screenshot of the rendered documentation? (the page snippet-compiler.html)

Copy link

@romanowskiromanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@romanowski
Copy link

cc @alvinj

@julienrfjulienrf removed their assignment Aug 2, 2021
@pikinier20pikinier20force-pushed the snippet-compiler-docs branch from 1183cd0 to dd6d83eCompareAugust 4, 2021 08:17
Copy link
Contributor

@alvinjalvinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a number of suggestions here, and I hope they’re hopeful. If you have any questions on any of my comments, please let me know. (Also, if I did anything wrong, please let me know that as well!) Thanks!

@pikinier20pikinier20force-pushed the snippet-compiler-docs branch from dd6d83e to 6d520f9CompareAugust 12, 2021 07:53
@julienrfjulienrf merged commit 52cf4b2 into scala:mainAug 24, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scaladoc: Documentation to Snippet Compiler

4 participants

@pikinier20@romanowski@alvinj@julienrf