Move Google copyright to file header#191
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The copyright should just be in the file header for the Elem and MetaData objects and classes, and not in their documentation. Currently, these copyright notices are showing up in the HTML api docs (scaladoc) for those elements. The rest of the library doesn't do this, so it's probably worth moving it out, rather than pasting copyright notices everywhere in the api docs for consistency. According to the original author of scala-xml, Burak Emir: The patch was built in 20% time while I was already working for Google, using Google's resources. The patch was formally reviewed and approved and Google is ok with it being part of Scala and people using, distributing, etc... it under the Scala license. That is why the copyright notice is there. See "committed to open source" in https://abc.xyz/investor/other/google-code-of-conduct.html
adriaanm approved these changes Feb 19, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copyright should just be in the source file header for the
ElemandMetaDataobjects and classes, and not in their documentation.Currently, these copyright notices are showing up in the HTML api docs (scaladocs) for those elements.
The rest of the library doesn't do this, so it's probably worth moving it out, rather than pasting copyright notices everywhere in the api docs for consistency.
According to the original author of scala-xml, Burak Emir:
I removed Burak Emir's contact information, since he's no longer involved in maintenance. It's well documented he wrote this library. It's not an intent to erase history.
The Google copyright was confusing to people in scala/bug#3405. But evidence above of Burak's statements, it is no mistake. Doesn't seem we can just remove them. That would violate basic copyright requirements.