Skip to content

Add support for Scala Native 0.4#482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SethTisue merged 8 commits into from
Jan 29, 2021
Merged

Add support for Scala Native 0.4 #482

SethTisue merged 8 commits into from
Jan 29, 2021

Conversation

@lolgab
Copy link
Contributor

@lolgablolgab commented Jan 23, 2021•
edited
Loading

Fixes: #282

@lolgablolgabforce-pushed the support-scala-native branch 7 times, most recently from a8fd9c9 to 079be9cCompareJanuary 23, 2021 19:06
@SethTisue
Copy link
Member

SethTisue commented Jan 28, 2021

I don't know Scala Native stuff, but this looks fine to me for merge after rebase 🤷

@lolgab do you feel there is any need for additional review here?

@lolgablolgabforce-pushed the support-scala-native branch from 217c467 to c805f48CompareJanuary 29, 2021 08:21
@lolgab
Copy link
ContributorAuthor

lolgab commented Jan 29, 2021

@SethTisue It sounds right to me and the tests pass, but let's ask @WojciechMazur if he can :)

WojciechMazur
WojciechMazur reviewed Jan 29, 2021
View reviewed changes
@lolgablolgabforce-pushed the support-scala-native branch from c805f48 to 047e953CompareJanuary 29, 2021 09:08
sjrd
sjrd reviewed Jan 29, 2021
View reviewed changes
@lolgab@sjrd
Simplify classpath search
79f9bb9
Co-authored-by: Sébastien Doeraene <[email protected]>
@lolgablolgab requested a review from sjrdJanuary 29, 2021 15:08
@SethTisue
Copy link
Member

SethTisue commented Jan 29, 2021•
edited
Loading

Would it be hard to also update the CircleCI config?

I don't really know where we stand with CircleCI. @ashawley added it as "experiment" and "backup" at #324

Personally, I'm fine with Travis-CI, or perhaps GitHub Actions in the future. Normally having two CI systems around doesn't really cost us anything.... except times when it does, like now. Or perhaps it would actually be simple to update?

@lolgablolgabforce-pushed the support-scala-native branch from 7b7f3a3 to e5f4e51CompareJanuary 29, 2021 16:16
@lolgab
Copy link
ContributorAuthor

lolgab commented Jan 29, 2021

@SethTisue Added a CircleCI job to test on Scala Native

@SethTisueSethTisue merged commit 7af5889 into scala:masterJan 29, 2021
@SethTisue
Copy link
Member

SethTisue commented Jan 29, 2021

thank you!!

@SethTisueSethTisue mentioned this pull request Jan 29, 2021
Closed
6 tasks
@SethTisue
Copy link
Member

SethTisue commented Jan 29, 2021

as for publishing it, #484

xuwei-k
xuwei-k reviewed Dec 31, 2021
View reviewed changes
.scalafmt.conf
@@ -0,0 +1 @@
version = "2.7.4"
Copy link
Contributor

@xuwei-kxuwei-kDec 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#582 (comment) 🤔

@xuwei-kxuwei-k mentioned this pull request Jan 23, 2022
Closed
@lolgablolgab deleted the support-scala-native branch January 23, 2022 08:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuwei-kxuwei-kxuwei-k left review comments

@WojciechMazurWojciechMazurWojciechMazur left review comments

@sjrdsjrdsjrd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scala Native Support

5 participants

@lolgab@SethTisue@xuwei-k@sjrd@WojciechMazur