Make -> sugar an inline method#24728
Open
+15 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bishabosha added the needs-minor-release 
MemberAuthor
I made it [error] -- [E007] TypeMismatchError: .../library/src/scala/collection/package.scala:71:16 [error] 71|elseSome(t.head -> t.tail) [error] |^^^^^^^^^^^^^^^^ [error] |Found: (A^'s1, C^{y$proxy1}) [error] |Required: (A, C) [error] | [error] |Note that capability y$proxy1 is not included in capture set{}. [error] |--------------------------------------------------------------------------- [error] |Inline stack trace [error] |-------------------------------------- [error] |This location contains code that was inlined from Predef.scala:616 [error] 616|inlinedef-> [B](y: B): (A, B) = (self, y) [error] |^^^^^^^^^ [error] --------------------------------------------------------------------------- [error] | [error] | longer explanation available when compiling with`-explain` |
Gedochao added the stat:feature freeze bishaboshaforce-pushed the feat/inlined-arrow-assoc branch from 73da792 to e62b7aeCompare
sjrd requested changes Dec 11, 2025
| // extension method sugar --------------------------------------------- | ||
| extension[A] (self: A) | ||
| transparentinlinedef-> [B](y: B): (A, B) = (self, y) |
Member
There was a problem hiding this comment.
This should really be a non-transparent. If it bothers CC, then CC must adapt.
Making this transparent inline has a huge cost in terms of compatibility guarantees. That should be avoided basically at all cost.
MemberAuthor
ok then lets say blocked by #24729 |
bishaboshaforce-pushed the feat/inlined-arrow-assoc branch from e62b7ae to 15b7d6cCompare
Must wait for 3.10.0 currently it is transparent inline, to avoid inline proxy objects appearing in capture sets and breaking type checking.
bishaboshaforce-pushed the feat/inlined-arrow-assoc branch from 15b7d6c to 69e9222CompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must wait for 3.10.0
currently it is transparent inline, to avoid inline proxy objects appearing in capture sets and breaking type checking.
fixes#24715