- Notifications
You must be signed in to change notification settings - Fork 54
Added format attribute to @Parameter#399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BoudewijnvanLangerak wants to merge 1 commit into scijava:master from BoudewijnvanLangerak:Add_format_to_parameter
Uh oh!
There was an error while loading. Please reload this page.
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions 101 src/test/java/org/scijava/command/ValidNumberCommandTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /* | ||
| * #%L | ||
| * SciJava Common shared library for SciJava software. | ||
| * %% | ||
| * Copyright (C) 2009 - 2020 SciJava developers. | ||
| * %% | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * 1. Redistributions of source code must retain the above copyright notice, | ||
| * this list of conditions and the following disclaimer. | ||
| * 2. Redistributions in binary form must reproduce the above copyright notice, | ||
| * this list of conditions and the following disclaimer in the documentation | ||
| * and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE | ||
| * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| * #L% | ||
| */ | ||
| packageorg.scijava.command; | ||
| importstaticorg.junit.Assert.assertEquals; | ||
| importstaticorg.junit.Assert.assertFalse; | ||
| importstaticorg.junit.Assert.assertNotNull; | ||
| importstaticorg.junit.Assert.assertTrue; | ||
| importjava.util.List; | ||
| importorg.junit.Before; | ||
| importorg.junit.Test; | ||
| importorg.scijava.Context; | ||
| importorg.scijava.ItemIO; | ||
| importorg.scijava.ValidityProblem; | ||
| importorg.scijava.plugin.Parameter; | ||
| importorg.scijava.plugin.Plugin; | ||
| /** | ||
| * Test commands for verifying that invalid module parameters are dealt with | ||
| * using proper error handling. | ||
| * | ||
| * @author Curtis Rueden | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ctrueden isn't the author of this class, right? I suppose this was just copy-pasted from the other test class? | ||
| */ | ||
| publicclassValidNumberCommandTest{ | ||
| privateCommandServicecommandService; | ||
| @Before | ||
| publicvoidsetUp(){ | ||
| Contextctx = newContext(CommandService.class); | ||
| commandService = ctx.getService(CommandService.class); | ||
| } | ||
| @Test | ||
| publicvoidtestValid(){ | ||
| finalCommandInfoinfo = commandService.getCommand(ValidCommand.class); | ||
| assertNotNull(info); | ||
| assertTrue(info.isValid()); | ||
| finalList<ValidityProblem> problems = info.getProblems(); | ||
| assertNotNull(problems); | ||
| assertEquals(0, problems.size()); | ||
| finalNumberstepSize = info.getInput("x").getStepSize(); | ||
| finalStringformat = info.getInput("x").getFormat(); | ||
| assertNotNull(stepSize); | ||
| assertEquals(10, stepSize.intValue()); | ||
| assertEquals("0.000000", format); | ||
| } | ||
| // -- Helper classes -- | ||
| /** A perfectly valid command! */ | ||
| @Plugin(type = Command.class) | ||
| publicstaticclassValidCommandimplementsCommand{ | ||
| @Parameter(stepSize = "10", format = "0.000000") | ||
| privatedoublex; | ||
| @Parameter(type = ItemIO.OUTPUT) | ||
| privateStringvalidOutput; | ||
| @Override | ||
| publicvoidrun(){ | ||
| validOutput = "ValidCommand: success!"; | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new API will break all implementations of
ModuleItem(except those extendingAbstractModuleItem, of course). It requires increasing the major version ofscijava-commonto3.x.x..