Skip to content

Conversation

@avilchess
Copy link
Contributor

Make sure you have checked all steps below.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits have been squashed if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

License

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.

@codecov
Copy link

codecovbot commented Mar 5, 2019

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #45 +/- ## ======================================= Coverage 94.56% 94.56% ======================================= Files 14 14 Lines 865 865 ======================================= Hits 818 818 Misses 47 47
FlagCoverage Δ
#Linux93.29% <ø> (ø)⬆️
#MacOS93.06% <ø> (ø)⬆️
#Windows94.21% <ø> (ø)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8be671...d602406. Read the comment docs.

Copy link
Contributor

@dcuestamdcuestam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@avilchessavilchess merged commit 55a7710 into masterMar 5, 2019
@avilchessavilchess deleted the fix/testDimensionality branch March 5, 2019 14:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@avilchess@dcuestam