SG-38306 Python2 Removal - Part 4 - Mimetypes module#401
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
Merged
julien-langforce-pushed the ticket/SG-38306-python2-removal-cleanup-imports branch from 9850464 to 6e89b98Comparejulien-langforce-pushed the ticket/SG-38306-python2-removal-mimetypes branch from 33e5200 to c4d1e30CompareContributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the deprecated Python 2.7 copy of the mimetypes module as part of the Python 2 removal effort. The codebase now exclusively uses Python's default mimetypes module since there are no longer any known issues with it after the transition away from Python 2.
Key changes:
- Removes the bundled Python 2.7 mimetypes module that was used to work around Windows-specific bugs in Python 2.7.0-2.7.9
- Simplifies the mimetypes import logic to directly import the standard library module
- Removes associated test code that was validating the conditional import behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shotgun_api3/lib/mimetypes.py | Complete removal of the bundled Python 2.7 mimetypes module (598 lines deleted) |
| shotgun_api3/shotgun.py | Simplifies mimetypes import by removing conditional logic and directly importing standard library module |
| tests/test_unit.py | Removes test class and import for the deprecated mimetypes fix functionality |
| shotgun_api3/lib/README.md | Removes documentation section explaining the bundled mimetypes module and associated Python 2.7 Windows bugs |
eduardoChaucaGallegos previously approved these changes Jul 18, 2025
Base automatically changed from ticket/SG-38306-python2-removal-cleanup-imports to masterSeptember 10, 2025 14:08
eduardoChaucaGallegos dismissed stale reviews from carlos-villavicencio-adsk and themself The base branch was changed.
eduardoChaucaGallegos approved these changes Sep 10, 2025
eduardoChaucaGallegos merged commit 8c5ef90 into master 22 checks passed
Uh oh!
There was an error while loading. Please reload this page.
eduardoChaucaGallegos deleted the ticket/SG-38306-python2-removal-mimetypes branch eduardoChaucaGallegos restored the ticket/SG-38306-python2-removal-mimetypes branch Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove now deprecated copy of Python 2.7's mimetypes module.
We prefer to use Python's default mimetypes module instead since we are not aware of any issues with this module anymore.
PR orders