Ticket/28817 fix api tests for new features#82
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nemoDreamer commented Mar 24, 2015
nemoDreamer commented - cherry-picked 2 improvements from Ticket/28441 hide template projects by default #79, to allow for less duplication later on.
- added version checks for Per-Project Customization parameter
- wrapped tests in version checks
nemoDreamerforce-pushed the ticket/28817_fix_api_tests_for_new_features branch from f4a5909 to 7a26d76Compare
There was a problem hiding this comment.
@manneohrstrom, I'd been tasked w/ fixing this, and only saw much later that you'd fixed the project aspect of this...
So this is the conflict resolution, I hope you don't mind I kept "mine", since I'd already cherry-picked my ensure_... changes over from #79...
There was a problem hiding this comment.
No worries at all - this was just a quick fix to get the tests working on older servers. Looks like you have done a much more holistic pass, trying to clean things up properly (which is totally awesome!). So please ignore/discard any of my changes in favour of your proper changes. This was just a quick fix to make sure we can release the API with all tests passing.
nemoDreamerforce-pushed the ticket/28817_fix_api_tests_for_new_features branch from 7a26d76 to 14e283eComparenemoDreamerforce-pushed the ticket/28817_fix_api_tests_for_new_features branch from 14e283e to 7963a06Compare…s_for_new_features Ticket/28817 fix api tests for new features
francoisjacques commented Apr 9, 2015
Awesome !! |
