Skip to content

Bearer token auth support#71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allmightyspiff merged 5 commits into from
Jan 14, 2021
Merged

Bearer token auth support #71

allmightyspiff merged 5 commits into from
Jan 14, 2021

Conversation

@allmightyspiff
Copy link
Member

@allmightyspiffallmightyspiff commented Jan 6, 2021

Adds a HttpBearerCredentials class to support using a Bearer token for API calls
Added code coverage report generation
Changed the examples to support either Bearer or username/apikey

@allmightyspiffallmightyspiff self-assigned this Jan 6, 2021
camporter
camporter reviewed Jan 6, 2021
View reviewed changes
camporter
camporter reviewed Jan 6, 2021
View reviewed changes
@allmightyspiffallmightyspiff linked an issue Jan 6, 2021 that may be closed by this pull request
Support for Bearer Authentication #70
Closed
@camportercamporter self-requested a review January 6, 2021 21:33
camporter
camporter reviewed Jan 13, 2021
View reviewed changes
@camporter
Copy link
Member

camporter commented Jan 13, 2021

Can we have the version updated in gen/pom.xml and examples/pom.xml as well?

camporter
camporter reviewed Jan 13, 2021
View reviewed changes
camporter
camporter reviewed Jan 13, 2021
View reviewed changes
FernandoOjeda
FernandoOjeda approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@FernandoOjedaFernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working well and it is looking good for me.

@allmightyspiffallmightyspiff merged commit 5ebe58f into softlayer:masterJan 14, 2021
@allmightyspiffallmightyspiff deleted the bearerTokenAuth branch January 14, 2021 20:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camportercamportercamporter approved these changes

+1 more reviewer

@FernandoOjedaFernandoOjedaFernandoOjeda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allmightyspiffallmightyspiff

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Bearer Authentication

3 participants

@allmightyspiff@camporter@FernandoOjeda