Refactor Configuration#219
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
NicoZelaya approved these changes Sep 28, 2018
| rescueStandardError=>error | ||
| @config.log_found_exception(__method__.to_s,error) | ||
| SplitIoClient.configuration.logger.info(SplitIoClient.configuration.block_until_ready) |
Contributor
There was a problem hiding this comment.
Is this just logging the number/boolean that was passed to the config? If you think it's better to surface the value in case of error here I won't argue with it, but maybe we should add something to the message to explain what that value represent.
If I'm reading this line wrong, disregard my comment.
ContributorAuthor
There was a problem hiding this comment.
Good catch @NicoZelaya I think it doesn't make sense to log this value. I'll remove this line.
ignaciosplitforce-pushed the refactor-configuration branch from 5931ca6 to 5c9f21eCompare
ignaciosplitforce-pushed the refactor-configuration branch from 5c9f21e to d6a5a04Compare
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a refactor for the configuration to implement a new pattern that avoids passing the
@configinstance throughout the library classes, clarifying the code thus increasing maintainability.It also adds:
specs. Simply by runningbundle exec rspec