Fixes for RSpec 3.13.0#258
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jas14force-pushed the fix-having-attributes-diff branch from 6c38951 to 4da87c6Compare
Specifically, ExpectedsForMultipleDiffs was renamed and refactored slightly.
OrderedOptions strikes again!
jas14force-pushed the fix-having-attributes-diff branch from 4da87c6 to 9ee96d5Comparejas14 merged commit 8c73488 into main 43 checks passed
Uh oh!
There was an error while loading. Please reload this page.
jas14 added a commit that referenced this pull request Nov 18, 2024
A private RSpec API (specifically `::RSpec::Matchers::{ExpectedsForMultipleDiffs -> MultiMatcherDiff}`) changed in 3.13.0; see rspec/rspec-expectations@81d3a58.Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restored from #251:
Added an Appraisal and implemented a couple fixes for compatibility with RSpec 3.13.0+. 🙂 This closes#250.
I'll admit that the version conditionals directly in the monkey patch file is rough. That file itself is also getting pretty large. I considered splitting up the patches into a
monkey_patches/directory and having each file define the version(s) to which it applies. Let me know if that sounds good and I'll be happy to implement it, either here or in a follow-up PR.