Support sending large STOMP messages as fragmented frames on WebSocketStompClient#31970
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spring-projects-issues added the status: waiting-for-triage 
injae-kimforce-pushed the send-stomp-messages-fragmented-frames branch from 824d2d3 to 43b272cCompare
injae-kim commented Jan 7, 2024
...-messaging/src/main/java/org/springframework/messaging/simp/stomp/SplittingStompEncoder.java Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
injae-kim commented Jan 7, 2024
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompDecoder.java Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
rstoyanchev added in: messaging 
Contributor
rstoyanchev left a comment
rstoyanchev left a comment There was a problem hiding this comment.
Overall the change looks good. I think it would be good to have dedicated unit tests for SplittingStompEncoder in spring-messaging in addition to the those in spring-websocket.
injae-kim commented Jan 9, 2024
...aging/src/test/java/org/springframework/messaging/simp/stomp/SplittingStompEncoderTests.java Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
injae-kimforce-pushed the send-stomp-messages-fragmented-frames branch from 43b272c to 05a990eCompare
ContributorAuthor
injae-kim commented Jan 14, 2024
(Rebase to latest main branch to resolve conflict~!) |
ContributorAuthor
injae-kim commented Jan 15, 2024
Seems mentioned +1 on #31901 😄 |
rstoyanchev pushed a commit that referenced this pull request Mar 12, 2024
rstoyanchev added a commit that referenced this pull request Mar 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closesgh-29354
Motivation
receivingbyBufferingStompDecoderlike other stomp libraries (e.g. stomp-websocket.js)sendingyet!Modification
SplittingStompEncoderto split large STOMP messages that exceedsoutboundMessageSizeLimitResult
WebSocketStompClient