Ensure removal of Content-Type header if body Publisher is empty#32622
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
spring-projects-issues added the status: waiting-for-triage 
ContributorAuthor
NadChel commented Apr 15, 2024
Is there something else I need to do to have it approved and merged? |
sbrannen changed the title Content-Type header if body Publisher is emptysbrannen added the in: web 
poutsma added type: enhancement poutsma added a commit that referenced this pull request Apr 23, 2024
poutsma added a commit that referenced this pull request Apr 23, 2024
…_type_if_no_body * gh-32622: Polishing external contribution Remove Content-Type when body is empty
Contributor
poutsma commented Apr 24, 2024
Thank you for submitting a PR. This will be in the upcoming 6.2M2 milestone. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a removal of
Content-Typeheader inorg.springframework.http.codec.EncoderHttpMessageWriterif the bodyPublisheris emptyAdded a couple of tests to assert on the writer's correct behavior when dealing with empty body
PublishersThe GH-32620 issue is a blocker for a Spring Cloud Gateway issue I've been researching