Skip to content

refactor: Make drivers classes instead of modules#21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyleconroy merged 3 commits into from
Mar 3, 2024
Merged

refactor: Make drivers classes instead of modules #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcebb89
WIP
kyleconroy Mar 3, 2024
f6c2c38
postgres
kyleconroy Mar 3, 2024
35e8ad1
Change driver from module to class
kyleconroy Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/app.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,10 +28,10 @@ import{
} from "./gen/plugin/codegen_pb"

import{argName, colName } from "./drivers/utlis"
import betterSQLite3 from "./drivers/better-sqlite3"
import pg from "./drivers/pg"
import postgres from "./drivers/postgres"
import mysql2 from "./drivers/mysql2"
import {Driver as Sqlite3Driver } from "./drivers/better-sqlite3"
import {Driver as PgDriver } from "./drivers/pg"
import {Driver as PostgresDriver } from "./drivers/postgres"
import {Driver as MysqlDriver } from "./drivers/mysql2"

// Read input from stdin
const input = readInput();
Expand DownExpand Up@@ -81,16 +81,16 @@ interface Driver{
function createNodeGenerator(driver?: string): Driver{
switch (driver){
case "mysql2":{
return mysql2;
return new MysqlDriver();
}
case "pg":{
return pg;
return new PgDriver();
}
case "postgres":{
return postgres;
return new PostgresDriver();
}
case "better-sqlite3":{
return betterSQLite3;
return new Sqlite3Driver();
}
}
throw new Error(`unknown driver: ${driver}`);
Expand DownExpand Up@@ -169,7 +169,7 @@ ${query.text}`
case ":execlastid":{
nodes.push(
driver.execlastidDecl(lowerName, textName, argIface, query.params)
)
);
break;
}
case ":one":{
Expand Down
Loading