docs: Reword phrase about pgx and multidimensional arrays#2619
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
andrewmbenton commented Aug 22, 2023
Good catch. I agree that your placement of "only" is much clearer. But we actually added support for multidimensional arrays with other driver packages (in #2338) and forgot to update this documentation, so the whole sentence can go. |
ContributorAuthor
rollulus commented Aug 23, 2023
Even better, thanks. |
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
sqlc-dev#2619) * docs: Reword phrase about pgx and multidimensional arrays * fix(docs): Remove multidimensional array qualification in datatypes.md --------- Co-authored-by: Andrew Benton <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English is not my native language, so I could be wrong, but my interpretation of the text was that pgx can only do multidimensional arrays, and nothing else. I think that's not right. Hope my commit corrects this.
Thanks for sqlc and best of luck with your company around it.